Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update frontend environment variables #3030

Merged
merged 3 commits into from
Nov 5, 2024
Merged

chore: update frontend environment variables #3030

merged 3 commits into from
Nov 5, 2024

Conversation

oana-lolea
Copy link
Contributor

@oana-lolea oana-lolea commented Oct 11, 2024 •
edited
Loading

Changes proposed in this pull request

  • Updated frontend environment variables: GRAPHQL_URL, OPEN_PAYMENTS_URL, ENABLE_INSECURE_MESSAGE_COOKIE, NODE_ENV, KRATOS_ADMIN_URL.
  • Changed start command in package.json.
  • Updated docs with the new changes.

Context

For this issue, I made the following changes:

  • Made GRAPHQL_URL and OPEN_PAYMENTS_URL mandatory and removed their default values.
  • Set NODE_ENV to production in docker files.
  • Set default value for ENABLE_INSECURE_MESSAGE_COOKIE to true in docker files and removed it from start script in package.json
  • Added KRATOS_ADMIN_URL to variables in envConfig.server.ts.
  • Updated frontend-variables.mdx.

Fixes #2994

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@github-actions github-actions bot added pkg: frontend Changes in the frontend package. pkg: mock-ase pkg: documentation Changes in the documentation package. labels Oct 11, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 11, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit d5ee331
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/670d2ae54be73900084a9f00

mkurapov
mkurapov reviewed Oct 14, 2024
View reviewed changes
packages/frontend/app/lib/message.server.ts Outdated Show resolved Hide resolved
packages/frontend/Dockerfile.dev Outdated Show resolved Hide resolved
packages/documentation/src/partials/frontend-variables.mdx
| `OPEN_PAYMENTS_URL` | frontend.serviceUrls.OPEN_PAYMENTS_URL | `http://localhost:3003/` | Open Payments API Endpoint |
| `PORT` | frontend.port | `3005` | Port from which to host the Remix app |
| `ENABLE_INSECURE_MESSAGE_COOKIE` | | _undefined_ | Values of `true`, `t`, `1` will not use a `secure` message cookie which is required for flash messages to work over http. When not set, the secure flag is set according to `NODE_ENV`. |
| Variable | Helm Value Name | Default | Description |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's tag @melissahenderson for this PR so she can make docs changes as necessary

@melissahenderson
Copy link
Contributor

Related to #2994

@melissahenderson
Copy link
Contributor

melissahenderson commented Oct 22, 2024 •
edited
Loading

Doc updates are ready to go in PR #3042, but I'm waiting for this issue and #2994 to be merged first. (Please let me merge my PR when it's time, there are prettier issues I need to fix first).

@melissahenderson melissahenderson mentioned this pull request Oct 22, 2024
Merged
@oana-lolea oana-lolea merged commit d30deeb into main Nov 5, 2024
30 of 42 checks passed
@oana-lolea oana-lolea deleted the 2994-frontend-env-variables branch November 5, 2024 09:53
@oana-lolea
Copy link
Contributor Author

@melissahenderson merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlie njlie njlie approved these changes

@mkurapov mkurapov mkurapov approved these changes

@melissahenderson melissahenderson Awaiting requested review from melissahenderson

Assignees
No one assigned
Labels
pkg: documentation Changes in the documentation package. pkg: frontend Changes in the frontend package. pkg: mock-ase user-docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frontend environment variables
4 participants
@oana-lolea @melissahenderson @mkurapov @njlie