Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix renovatebot #3058

Merged
merged 1 commit into from
Oct 31, 2024
Merged

chore: fix renovatebot #3058

merged 1 commit into from
Oct 31, 2024

Conversation

mkurapov
Copy link
Contributor

@mkurapov mkurapov commented Oct 31, 2024

Changes proposed in this pull request

Fixing renovatebot via update of renovate.json file: instead of using

"ignorePaths": ["!test/**"]

(which was causing only renovatebot to check the integration test folder),
we duplicate the rule in the default config:base preset to

  "ignorePaths": [
    "**/node_modules/**",
    "**/bower_components/**",
    "**/vendor/**",
    "**/examples/**",
    "**/__tests__/**",
    "**/tests/**",
    "**/__fixtures__/**"
  ]

making sure to not include "/test/".

Context

Fixes #3056

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit ba2a317
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/6723a5ff3863af0008611c91

@mkurapov mkurapov changed the title chore: update renovate.json file chore: fix renovatebot Oct 31, 2024
@mkurapov mkurapov marked this pull request as ready for review October 31, 2024 15:45
Copy link
Contributor

@BlairCurrey BlairCurrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Although do we need to do "ignorePresets": [":ignorePaths"] ? I guess probably not and we can just override like this. I suppose we'll find out pretty fast.

FWIW I was curious how often these change and it looks like they haven't changed in a minimum of 4 years (although probably longer). Regardless, it will not be hard to update and generally doesn't matter to not be in sync. https://github.com/renovatebot/renovate/blame/4abd0abea82a8880a91c2e3c4e1216ffbc8459c6/lib/config/presets/internal/default.ts

@mkurapov mkurapov merged commit a7417e6 into main Oct 31, 2024
30 of 42 checks passed
@mkurapov mkurapov deleted the 3056/mk/fix-renovate-bot branch October 31, 2024 15:53
@BlairCurrey
Copy link
Contributor

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix renovate bot
2 participants