-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fixes 3084 #3088
base: main
Are you sure you want to change the base?
docs: fixes 3084 #3088
Conversation
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Continue Grant POST is for the Open Payments Auth API, so shouldn't be in the IdP spec |
packages/documentation/src/content/docs/integration/requirements/wallet-addresses.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/src/content/docs/integration/requirements/wallet-addresses.mdx
Outdated
Show resolved
Hide resolved
@@ -194,11 +193,11 @@ Open Payments <LinkOut href="https://openpayments.dev/apis/wallet-address-server | |||
|
|||
<div class="overflow-table"> | |||
|
|||
| Parameter | Required value | Description | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this auto-formatted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we run prettier on the docs, it adds a bunch of extra spaces within all the markdown table columns and rows. That makes it harder for the writers to 'read' the tables and edit them later. Sarah's given us a temporary workaround where prettier will ignore the tables (actually, maybe all the doc files) and keep our original formatting. So this was me putting the table back to its original formatting.
This PR covers doc issues that were discussed during a meeting with Max on Nov. 05, 2024.
@mkurapov Tagging you because of the YAML updates. Also, the OpenAPI spec for IdP is missing
Continue Grant POST /interact/{id}/{nonce}
. Is that intentional or should I create an issue for it?