Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix extension build windows environment #711

Closed
DarianM opened this issue Nov 13, 2024 · 0 comments · Fixed by #712
Closed

[BUG] Fix extension build windows environment #711

DarianM opened this issue Nov 13, 2024 · 0 comments · Fixed by #712
Assignees
Labels
area: scripts Improvements or additions to custom scripts bug Something isn't working

Comments

@DarianM
Copy link
Member

DarianM commented Nov 13, 2024

Steps to reproduce

  1. Run the esbuild build process on a Windows machine.
  2. Observe that the copy plugin fails to copy the files correctly in either production or development build dirs

Expected result

The copy plugin should be able to copy all the files correctly, regardless of the operating system (Windows, Linux, or macOS).

Actual result

When using the copy plugin from the esbuild-plugin-copy package on Windows, the file paths are not being correctly interpreted, leading to the plugin failing to copy the files.

Different file path conventions between Windows and other operating systems like Linux and macOS. On Windows, file paths typically use backslashes ( \ ) as the directory separator, while on Linux and macOS, the standard directory separator is a forward slash ( / ).

The copy plugin from the esbuild-plugin-copy package is designed to work with file paths using forward slashes, as this is the standard convention for file paths in js and most modern web development tools. When you use backslashes on Windows, the copy plugin is unable to properly interpret the file paths, leading to this issue.

Screenshots or videos

image

  • missing _locales
  • missing assets
  • missing pages/progress-connect/index.html
  • missing popup/index.html

Additional context

To resolve this problem on Windows, we need to convert the backslashes to forward slashes in the from and to paths passed to the copy plugin.

Operating system

Windows, Linux

Operating system version

No response

Browsers

Firefox

Browser version

No response

Extension version

0.1.0

@DarianM DarianM added bug Something isn't working triage Waiting to be assigned labels labels Nov 13, 2024
@DarianM DarianM self-assigned this Nov 13, 2024
@DarianM DarianM linked a pull request Nov 13, 2024 that will close this issue
@DarianM DarianM moved this from Backlog to In Review in Web Monetization Extension Nov 13, 2024
@sidvishnoi sidvishnoi added area: scripts Improvements or additions to custom scripts and removed triage Waiting to be assigned labels labels Nov 14, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web Monetization Extension Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: scripts Improvements or additions to custom scripts bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants