-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scripts/build): use correct asset-copy paths on Windows #712
fix(scripts/build): use correct asset-copy paths on Windows #712
Conversation
Extension builds preview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can directly use path.posix.join()
instead to force forward slashes everywhere.
@sidvishnoi
we can use path.posix directly, would first need to convert all input paths to use forward slashes from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think cleanest would be adding a util (say toPosix
) and just call it to replace all windows separators to posix type, only for the copy plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. Thanks @DarianM and congrats on your first PR here 🎉
Context
The copy plugin should be able to copy all the files correctly, regardless of the operating system (Windows, Linux, or macOS).
Closes #711 .
Changes proposed in this pull request
Convert the backslashes to forward slashes in the from and to paths passed to the copy plugin.