-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): update workflows #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22.
This PR updates the current workflow files and adds a couple of new ones:
sanity
- will be triggered whenever we push on themain
branchpr-checks
- will be triggered whenever a new PR is createdbuild-previews
- will be triggered when thepr-checks
workflow is finished (on success or failure - the status does not matter)pr-checks
action gets cancelleddelete-pr-artifacts
- will be triggered when a PR is closedConcerns
The
build-previews
workflow might not be triggered when a PR is made from a fork (still needs a bit of research). The primary goal was to ensure that the previews are available for us when we create a PR, allowing us to test all the changes.The comment with all the links will be added when the workflow will be in the
main
branch, that's why for this PR the build previews are not available.Comment preview