Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(background): use default icon on non-http/https tabs #549

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

sidvishnoi
Copy link
Member

Context

From Jeremiah's feedback:

When creating a new tab, which is a page without a wallet address, the bright red icon stole my attention. ... I thought something was wrong or needed my attention.

Changes proposed in this pull request

@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Aug 29, 2024
Copy link
Contributor

github-actions bot commented Aug 29, 2024

Extension builds preview

Name Link
Latest commit 827340b
Latest job logs Run #10700086855
BadgeDownload
BadgeDownload

Copy link
Member

@raducristianpopa raducristianpopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss this in tomorrow's call. Please add it as an agenda item.

src/background/services/tabEvents.ts Outdated Show resolved Hide resolved
@sidvishnoi sidvishnoi merged commit a6da5ac into main Sep 4, 2024
8 checks passed
@sidvishnoi sidvishnoi deleted the default-icon-new-tab branch September 4, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants