refactor(popup/ConnectWalletForm): reduce reliance on browser APIs #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: popup
Extension builds preview
|
){kind=icon}
){kind=icon}
sidvishnoi
changed the title
src/popup/pages/Settings.tsx
Outdated
| walletAddressUrl: | ||
| localStorage?.getItem('connect.walletAddressUrl') || undefined, | ||
| }} | ||
| onChange={(key, val) => { |
There was a problem hiding this comment.
I'm thinking about giving this a better name. Something like saveToStorage.
raducristianpopa
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#565 introduces some more validation. So simplifying this component to make it more testable.
Changes proposed in this pull request
localStorage(replace withdefaultValuesandonChangeprops).browser.runtime.sendMessage/useMessage(replace withconnectWalletprop)fetch/getWalletInformation(replace withgetWalletInfoprop)connect.