Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store and send transient state to popup #628

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Sep 25, 2024

Context

Closes #626
Part of #613

Changes proposed in this pull request

Now if the user opens popup after clicking connect (as popup closes on new tab open on consent screen), they'll see the spinner that connecting is in progress.

@github-actions github-actions bot added area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup labels Sep 25, 2024
Copy link
Contributor

github-actions bot commented Sep 25, 2024

Extension builds preview

Name Link
Latest commit 5058b09
Latest job logs Run #11045062130
BadgeDownload
BadgeDownload

@sidvishnoi sidvishnoi marked this pull request as ready for review September 25, 2024 14:40
@sidvishnoi sidvishnoi merged commit 66f5d32 into main Sep 26, 2024
8 checks passed
@sidvishnoi sidvishnoi deleted the popup-transient-state branch September 26, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]: add transient state for when popup closes
2 participants