Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use network requests for auto-add key to Fynbos #649

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

raducristianpopa
Copy link
Member

@raducristianpopa raducristianpopa commented Oct 9, 2024

Changes proposed in this pull request

Instead of performing DOM actions, call the routes directly to upload the public key.

@github-actions github-actions bot added area: content Improvements or additions to extension content script area: background Improvements or additions to extension background script labels Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Extension builds preview

Name Link
Latest commit a5eaa12
Latest job logs Run #11270245199
BadgeDownload
BadgeDownload

@github-actions github-actions bot removed the area: background Improvements or additions to extension background script label Oct 9, 2024
@raducristianpopa raducristianpopa marked this pull request as ready for review October 9, 2024 16:56
src/content/keyAutoAdd/fynbos.ts Outdated Show resolved Hide resolved
src/content/keyAutoAdd/fynbos.ts Outdated Show resolved Hide resolved
@sidvishnoi sidvishnoi changed the title feat: proposal for Fynbos automatic key add fix: use network requests for auto-add key to Fynbos Oct 10, 2024
@sidvishnoi sidvishnoi merged commit ed6eae7 into fynbos-key-add Oct 10, 2024
8 checks passed
@sidvishnoi sidvishnoi deleted the rp/fynbos-key-add-proposal branch October 10, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: content Improvements or additions to extension content script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants