-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(popup/Settings)!: split settings into tabbed interface #657
Conversation
Extension builds preview
|
@sidvishnoi few comments:
|
Eventually yes, but not in this PR. It'll get too big, and that input isn't as simple if done right.
Rate of pay gets handled immediately, like before. |
Ok for rate of pay slider. |
We'd need UI to support edits first then. We need submit buttons somewhere, and a messaging that they'll need to connect wallet again (it'll open new tab to connect that is, so we can't just to do it in input). |
Why do they need to connect to the wallet again? |
Does that mean that switching between monthly or not will cause the same issues |
When they change budget (any part of it - amount or recurring), we need to create a new interactive grant (i.e. ask user for permission), which happens in a new tab. So, it's the same connect wallet process again, but only without the need to add key again.
Yes. Same issues. Changing any part of budget/grant. |
You mean the part on the browser to accept the grant? or the connect screen on the extension? |
Yes.
Yes, wrong control if it's not meant to be editable. Point #3 in Slack |
Will do budget-edit support as a follow-up PR. Keeping this PR limited to tab-UI thing only. |
Context
Changes proposed in this pull request