Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use new test wallet URL; update keyAutoAdd, tests, popup #671

Merged
merged 4 commits into from
Oct 18, 2024
Merged

fix: use new test wallet URL; update keyAutoAdd, tests, popup #671

merged 4 commits into from
Oct 18, 2024

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Oct 15, 2024 •
edited
Loading

Closes #670

@github-actions github-actions bot added area: content Improvements or additions to extension content script area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup area: tests Improvements or additions to tests labels Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Extension builds preview

Name Link
Latest commit 309963d
Latest job logs Run #11401614277
BadgeDownload
BadgeDownload

raducristianpopa
raducristianpopa reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@raducristianpopa raducristianpopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

sidvishnoi
sidvishnoi commented Oct 18, 2024
View reviewed changes
Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@sidvishnoi sidvishnoi marked this pull request as ready for review October 18, 2024 10:00
@sidvishnoi
Copy link
Member Author

Updated key in GitHub and added to linked test wallet address.

sidvishnoi
sidvishnoi commented Oct 18, 2024
View reviewed changes
Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@sidvishnoi sidvishnoi merged commit 0004cb9 into main Oct 18, 2024
12 of 14 checks passed
@sidvishnoi sidvishnoi deleted the testwallet-new branch October 18, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raducristianpopa raducristianpopa raducristianpopa approved these changes

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script area: content Improvements or additions to extension content script area: popup Improvements or additions to extension popup area: tests Improvements or additions to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update keyAutoAdd for new test wallet
2 participants
@sidvishnoi @raducristianpopa