Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bg/PaymentSession): never return undefined from pay() #702

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

sidvishnoi
Copy link
Member

Extracted from #694

Will either throw or retry, but never return undefined.

@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Extension builds preview

Name Link
Latest commit a056f29
Latest job logs Run #11722883436
BadgeDownload
BadgeDownload

@sidvishnoi sidvishnoi merged commit 859cd85 into main Nov 7, 2024
9 checks passed
@sidvishnoi sidvishnoi deleted the PaymentSession.pay-returntype branch November 7, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants