refactor(tests/e2e): simplify openPopup helper
#706
Conversation
Extension builds preview
|
){kind=icon}
){kind=icon}
| ) { | ||
| const url = getPopupUrl({ browserName, channel }, extensionId); | ||
| const url = await background.evaluate(() => chrome.action.getPopup({})); |
There was a problem hiding this comment.
Might it be worth to use browser from polyfill instead of chrome?
There was a problem hiding this comment.
That'll require importing polyfill in each evaluate context.
There was a problem hiding this comment.
Will check if Playwright lets us define such polyfills (like globally). But chrome is supposed to work in Edge/Chrome and Firefox.
There was a problem hiding this comment.
In most cases, something like const browser = globalThis.browser || globalThis.chrome should be enough (we don't need full polyfill).
There was a problem hiding this comment.
I couldn't find a way for now, but something like exposeBinding would be the way. Or we can make browser a global in background.js
Something of a general problem, I think I will check that as a followup.
Discovered when writing article for end-to-end testing 😄