feat: generate keys when extension is installed #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: background
){kind=icon}
){kind=icon}
){kind=icon}
){kind=icon}
dianafulga
previously approved these changes
Feb 20, 2024
| @@ -53,6 +55,33 @@ class Background { | |||
| unsubscribeFromMessages() { | |||
| this.subscriptions.forEach((sub: any) => sub()) | |||
| } | |||
|
|
|||
| private async keyExists(): Promise<boolean> { | |||
There was a problem hiding this comment.
there is no reason for this method to be here, it's independent of the background class. Maybe a better place would be the storage wrapper to access different variables in there
There was a problem hiding this comment.
Currently, there isn't a storage wrapper available. Once the storage wrapper is implemented, transferring it there will be straightforward. I'll add a comment.
raducristianpopa
force-pushed
the
rp--generate-keys
branch
from
43a092f
to
e5a4ed5
Compare
ionutanin
approved these changes
Feb 21, 2024
dianafulga
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #92.
Changes proposed in this pull request
Whenever the extension is installed, the key pair is generated, alongside a key ID: