-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: build and push Docker image #60
base: master
Are you sure you want to change the base?
Conversation
@adrianhopebailie can do that for you @wilsonianb. I think we do have it already setup for some other repos already. Would it not make more sense for the main moneyd repo to have a docker container and then pass options/arguments in for the specific uplinks? Put differently, why would the uplink need its own docker image? |
Moneyd would need to be packaged with all the uplinks for that to work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adrianhopebailie can you add the credentials for this to circle? then it can be merged
At Matt's suggestion, I'm going to try having Dockerhub handle the image building. |
TIL you can't reopen a pull request if you've force pushed since closing it |
I've created a Dockerhub repo and configured it to autobuild and publish images for master and tags.
Would including moneyd and the uplinks in the interledgerjs monorepo make that possible? |
This would require us to add interledgerjs(?) docker hub account credentials to circleci