Skip to content

Commit

Permalink
update sslyze fork, set correct ehlo name
Browse files Browse the repository at this point in the history
  • Loading branch information
mxsasha committed Aug 28, 2024
1 parent e983c31 commit 9f3a295
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion checks/tasks/tls/scans.py
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,7 @@ def check_mail_tls_multiple(server_tuples, task) -> Dict[str, Dict[str, Any]]:
network_configuration = ServerNetworkConfiguration(
tls_server_name_indication=server,
tls_opportunistic_encryption=ProtocolWithOpportunisticTlsEnum.SMTP,
smtp_ehlo_hostname=settings.SMTP_EHLO_DOMAIN,
)
supported_tls_versions = check_supported_tls_versions(
ServerConnectivityInfo(
Expand Down Expand Up @@ -515,7 +516,7 @@ def check_mail_tls_multiple(server_tuples, task) -> Dict[str, Dict[str, Any]]:
)
except TLSException as exc:
log.info(f"sslyze scan for mail failed: {exc}")
# TODO: fix this
# TODO: fix this and refine it to apply to specific server
return dict(server_reachable=False, tls_enabled=False)
return results

Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ COPY requirements.txt /src/requirements.txt
WORKDIR /src

RUN pip3 install -r requirements.txt
RUN pip3 install --no-deps https://github.com/mxsasha/sslyze/archive/refs/tags/6.0.0+internetnl2.tar.gz
RUN pip3 install --no-deps https://github.com/mxsasha/sslyze/archive/refs/tags/6.0.0+internetnl3.tar.gz

# stage with app dependencies and lint/test depencencies
FROM --platform=linux/amd64 build-app-deps as linttest-deps
Expand Down

0 comments on commit 9f3a295

Please sign in to comment.