Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Positive Definate Woodbury #2

Merged
merged 7 commits into from
Nov 16, 2020
Merged

Add Positive Definate Woodbury #2

merged 7 commits into from
Nov 16, 2020

Conversation

oxinabox
Copy link
Member

First commit.
First commit is just the old close-source code.

Only real change is to use ChainRulesCore rather than Zygote to make non-differnetiable.
Some updates to the tests.

Particular fiddly was realising that their was a breaking change in Distributions 0.23.8->0.23.9 that snuck though.
JuliaStats/Distributions.jl#1160

@codecov-io
Copy link

codecov-io commented Nov 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f14d32b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   62.82%           
=========================================
  Files             ?        3           
  Lines             ?       78           
  Branches          ?        0           
=========================================
  Hits              ?       49           
  Misses            ?       29           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f14d32b...d042e64. Read the comment docs.

Copy link
Member

@rofinn rofinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple minor suggestions.

Project.toml Show resolved Hide resolved
test/woodbury_pd_mat.jl Show resolved Hide resolved
@oxinabox
Copy link
Member Author

CI is only failing on nightly, because Zygote doesn't work on nightly

@oxinabox oxinabox merged commit f5042d5 into master Nov 16, 2020
@oxinabox oxinabox deleted the ox/woodbury branch November 16, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants