-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Positive Definate Woodbury #2
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=========================================
Coverage ? 62.82%
=========================================
Files ? 3
Lines ? 78
Branches ? 0
=========================================
Hits ? 49
Misses ? 29
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple minor suggestions.
CI is only failing on nightly, because Zygote doesn't work on nightly |
First commit.
First commit is just the old close-source code.
Only real change is to use ChainRulesCore rather than Zygote to make non-differnetiable.
Some updates to the tests.
Particular fiddly was realising that their was a breaking change in Distributions 0.23.8->0.23.9 that snuck though.
JuliaStats/Distributions.jl#1160