sessions: addition of KVSession interface #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drjova
force-pushed
the
create-session-interface
branch
2 times, most recently
from
89991aa
to
0bdc7e7
Compare
drjova
changed the title
drjova
force-pushed
the
create-session-interface
branch
from
0bdc7e7
to
df00af1
Compare
|
@slint updated |
kpsherva
reviewed
Mar 3, 2020
| @@ -152,3 +154,14 @@ def default_session_store_factory(app): | |||
| accounts_session_redis_url)) | |||
| from simplekv.memory import DictStore | |||
| return DictStore() | |||
|
|
|||
|
|
|||
| class KVSessionInterfaceWithAnonymousSessions(KVSessionInterface): | |||
There was a problem hiding this comment.
small impact: IMO the name indicates that we store sessions for anonymous. I would suggest KVSessionInterfaceStoreAuthenticated, also is it possible to test it?
Signed-off-by: Harris Tzovanakis <[email protected]>
diegodelemos
force-pushed
the
create-session-interface
branch
from
df00af1
to
382f8b8
Compare
|
Working using latest ~/invenio-accounts $ git diff
diff --git a/setup.py b/setup.py
index 0eed598..81e41f9 100644
--- a/setup.py
+++ b/setup.py
@@ -75,7 +75,7 @@ install_requires = [
'email-validator>=1.0.5',
'future>=0.16.0',
'invenio-base>=1.2.2',
- 'invenio-i18n>=1.2.0',
+ 'invenio-i18n<1.2.0,>=1.1.1',
'invenio-celery>=1.1.2',
'invenio-rest>=1.1.3',
'maxminddb-geolite2>=2017.404',
~/invenio-accounts $ cd ../ && cookiecutter cookiecutter-invenio-instance
$ cd my-site
$ cat my_site/config.py
...
# Sessions
# ========
#: Whether the instance should use SameSite cookies to store client sessions.
SESSION_COOKIE_SAMESITE = 'Strict'
...
$ ./scripts/bootstrap
$ ./scripts/setup
$ pipenv install ../invenio-accounts # the dev version
$ pip env shell
$ pip uninstall flask-kvsession -y
$ pip show flask-kvsession-invenio
Name: Flask-KVSession-Invenio
Version: 0.6.3
...
$ ./scripts/server
Note: Invenio-i18n version needs to be changed because Invenio 3.2.1 doesn't support it, but this doesn't change anything regarding Flask-KVSession integration We need to:
CC @ppanero. |
This was referenced May 11, 2020
Glignos
force-pushed
the
create-session-interface
branch
from
5d944cf
to
be9bd3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harris Tzovanakis [email protected]
Closes #289.