Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add cancel all except current queue item functionality #7395

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(ui): add cancel all except current queue item functionality #7395

wants to merge 3 commits into from

Conversation

rikublock
Copy link
Contributor

@rikublock rikublock commented Nov 28, 2024 •
edited
Loading

Summary

Adds support for "cancel all except current queue item":

  • backend api functionality
  • queue action menu entry with alert dialog

Related Issues / Discussions

#7367

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added api python PRs that change python files services PRs that change app services frontend PRs that change frontend files labels Nov 28, 2024
@magnusviri
Copy link
Contributor

I synced my local repo to this branch and built and ran it but didn't see the new button.

@rikublock rikublock force-pushed the riku/feat-cancel-all-except-current branch from 1f0a154 to 0f40e2a Compare December 6, 2024 08:50
@rikublock rikublock marked this pull request as ready for review December 6, 2024 08:52
@psychedelicious
Copy link
Collaborator

@rikublock For some reason I thought this PR was not ready for review. Is that correct? Sorry if I have forgotten about this!

@rikublock
Copy link
Contributor Author

@rikublock For some reason I thought this PR was not ready for review. Is that correct? Sorry if I have forgotten about this!

It was marked as a draft for a while (with a note saying, 'Do not merge yet'). I should have made it clearer that it is ready now.

psychedelicious
psychedelicious reviewed Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks! Will be very nice to have this button.

We have a tight schedule over the next week with the upcoming v5.5.0 release and associated hosted product code changes. I don't want to delay things by adding queue service changes to the list, so I'm probably going to hold off on merging this until after v5.5.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious left review comments

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api frontend PRs that change frontend files python PRs that change python files services PRs that change app services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rikublock @magnusviri @psychedelicious