Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 compatibility #232

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Python 3.11 compatibility #232

wants to merge 4 commits into from

Conversation

danigm
Copy link

@danigm danigm commented Jan 17, 2023

This patch adds the new arguments to the types.CodeType class constructor in the clonefunc function.

See #231

This patch adds the new arguments to the types.CodeType class
constructor in the clonefunc function.

See ionelmc#231
@danigm danigm marked this pull request as ready for review January 17, 2023 12:37
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.01 🎉

Comparison is base (7ef2645) 64.41% compared to head (254edb6) 64.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   64.41%   64.43%   +0.01%     
==========================================
  Files          29       29              
  Lines        2858     2862       +4     
  Branches      386      469      +83     
==========================================
+ Hits         1841     1844       +3     
- Misses        927      928       +1     
  Partials       90       90              
Impacted Files Coverage Δ
src/pytest_benchmark/compat.py 0.00% <0.00%> (ø)
tests/test_benchmark.py 100.00% <ø> (ø)
src/pytest_benchmark/utils.py 41.60% <75.00%> (+0.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jan 18, 2023
https://build.opensuse.org/request/show/1059005
by user dgarcia + dimstar_suse
- Modify the py311.patch to fix the test_abort_broken test, instead of
  disabling.
- Add py311.patch to make it compatible with python 3.11,
  gh#ionelmc/pytest-benchmark#232
- Disable broken test_abort_broken, this test is broken because the output of
  the tests is a bit different with python 3.11 so we can disable until it's
  fixed.
@ngie-eign
Copy link

.github workflows, etc, needs to be updated.

@ngie-eign
Copy link

I updated setup.py and CHANGELOG.rst in #237 as well. I think that's everything that needs to be done.
I can close my PR in favor of your's.

@ngie-eign
Copy link

LGTM -- but I'm not a contributor, so sorry -- can't provide approval 😅 .

@ngie-eign
Copy link

ngie-eign commented Mar 13, 2023

PS You might need to rebase if you haven't done so recently, since this was originally based on sources from 2 months ago. I wouldn't do anything about that unless it's absolutely needed, or the maintainers ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants