fix(icon): sanitizer checks attribute name instead of value (#1087)

resolves #1088
ionic-team · Aug 26, 2022 · 8d898d7 · 8d898d7
1 parent 7dd6909
commit 8d898d7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/components/icon/test/validate.spec.ts b/src/components/icon/test/validate.spec.ts
@@ -7,7 +7,7 @@ describe('isValid', () => {
     const el = {
       nodeType: 1,
       nodeName: 'svg',
-      attributes: [{ value: 'onload' }],
+      attributes: [{ name: 'onload' }],
       childNodes: []
     } as any;
     expect(isValid(el)).toBe(false);
@@ -17,7 +17,7 @@ describe('isValid', () => {
     const el = {
       nodeType: 1,
       nodeName: 'svg',
-      attributes: [{ value: 'OnClIcK' }],
+      attributes: [{ name: 'OnClIcK' }],
       childNodes: []
     } as any;
     expect(isValid(el)).toBe(false);

diff --git a/src/components/icon/validate.ts b/src/components/icon/validate.ts
@@ -34,8 +34,8 @@ export const isValid = (elm: HTMLElement) => {
     }
 
     for (let i = 0; i < elm.attributes.length; i++) {
-      const val = elm.attributes[i].value;
-      if (isStr(val) && val.toLowerCase().indexOf('on') === 0) {
+      const name = elm.attributes[i].name;
+      if (isStr(name) && name.toLowerCase().indexOf('on') === 0) {
         return false;
       }
     }