Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the maximum file limit for POSIX systems #580

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

acronce
Copy link

@acronce acronce commented Dec 4, 2022

  • Resolves an issue I saw where the macOS application's dylibs could not be loaded because I had too many maps.
  • Due to not so great error logging, this problem was non-obvious. Ultimately I managed to spot the error 24, which is means too many open files.
  • On macOS the default number of open files is 256 (without this change).
  • The Windows implementation currently does nothing, but that's reasonable because the limit is quite large (10k I think).

- Resolves an issue I saw where the macOS application's dylibs could not be loaded because I had too many maps.
- Due to not so great error logging, this problem was non-obvious. Ultimately I managed to spot the error 24, which is means too many open files.
- On macOS the default number of open files is 256 (without this change).
- The Windows implementation currently does nothing, but that's reasonable because the limit is quite large (10k I think).
- Simplified the implementation and made it more POSIX based and less macOS.
- Handle the rare failure case on older macOS versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant