Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable modifying Block Issuer Keys in CLI Wallet #2235

Merged
merged 12 commits into from
Apr 29, 2024
Merged

Enable modifying Block Issuer Keys in CLI Wallet #2235

merged 12 commits into from
Apr 29, 2024

Conversation

PhilippGackstatter
Copy link
Contributor

Description of change

Enable modifying Block Issuer Keys in CLI Wallet. This is so prospect validators can easily add a second dedicated block issuer key for use in inx-validator. It needs the private key corresponding to the block issuer key in order to be able to issue validation blocks. Since the private key of the block issuer key added by the sdk is in stronghold or the ledger and thus not extractable, a new command was necessary to be able to add external block issuer keys.

Links to any relevant issues

n/a

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Manual local testing with the cli.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Thoralf-M
Thoralf-M previously approved these changes Apr 29, 2024
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reopened a comment just to be sure, resolve again if you want

@thibault-martinez thibault-martinez merged commit e5e80d3 into iotaledger:2.0 Apr 29, 2024
37 checks passed
@PhilippGackstatter PhilippGackstatter deleted the feat/cli-wallet-block-issuer-keys branch April 29, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants