feat(types)!: use Mnemonic type from crypto.rs
#471
Conversation
Alex6323
changed the title
Mnemonic type that is ZeroizeOnDropMnemonic type that is ZeroizeOnDrop
Alex6323
force-pushed
the
feat/types/zeroize-on-drop-mnemonic-type
branch
from
9cc642c
to
a8de867
Compare
There was a problem hiding this comment.
We should wait and use the Mnemonic from iotaledger/crypto.rs#200
* Allow SecretManage to be extensible * fix type * more feature gating * Fix stronghold backup/restore * Fix backup restore bugs * clippy * feature 🐊 * LINE PIECE | Co-authored-by: Thibault Martinez <[email protected]> * imports * fix merge * PR suggestions * changelog * cleanup * fix merge * fix borked merge * nit * Remove Debug requirement from StorageManage * comment * clippy * Remove generate addresses that is not needed * remove more generate addresses * cleanup * Fix features and clippy * flip the switch --------- Co-authored-by: Thibault Martinez <[email protected]>
|
iotaledger/crypto.rs#200 was merged, I don't know if there was something else in this PR that we would keep? |
|
Things we probably want to keep from this PR: |
|
I agree, those aspects should be maintained. |
|
Waiting for #715 to be merged which will make their |
Alex6323
changed the title
Mnemonic type that is ZeroizeOnDropMnemonic type from crypto.rs
| @@ -154,6 +154,76 @@ impl MnemonicSecretManager { | |||
| } | |||
| } | |||
|
|
|||
| // impl From<Mnemonic> for MnemonicSecretManager { | |||
There was a problem hiding this comment.
What's up with all this ?
There was a problem hiding this comment.
don't think too much about it ... I merged develop into this branch to see in GH if there's something left of use and just out-commented this for the time being.
|
Changes of this PR were already done in #715 |
Description of change
Consistent with the new
Passwordtype in #468 this PR adds aMnemonictype, that makes sure sensitive data gets zeroed when the owner is being dropped.Links to any relevant issues
None
Type of change
How the change has been tested
Unit tests