Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run tests for sdk and bindings/core #782

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Only run tests for sdk and bindings/core #782

merged 3 commits into from
Jul 14, 2023

Conversation

Thoralf-M
Copy link
Member

Description of change

Only run tests for sdk and bindings/core

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

CI will test

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Thoralf-M Thoralf-M marked this pull request as ready for review July 14, 2023 09:23
thibault-martinez
thibault-martinez requested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing

@Thoralf-M Thoralf-M marked this pull request as draft July 14, 2023 10:07
@Thoralf-M Thoralf-M marked this pull request as ready for review July 14, 2023 10:46
@thibault-martinez thibault-martinez merged commit b1cdd65 into iotaledger:develop Jul 14, 2023
22 checks passed
@Thoralf-M Thoralf-M deleted the ci-tests branch July 14, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thoralf-M @thibault-martinez @DaughterOfMars