-
Notifications
You must be signed in to change notification settings - Fork 20
feat!: IPNS routing based on IPIP-351 or IPIP-379 #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for cleaning this up.
Perhaps we could clean up bit more – see DefaultKuboRPC
comment inline.
We haven't had testing before and it seems a bit complicated to automate. I tried locally with both Kubo gateway and Routing V1 and it worked partying_face
I think this is already handled by gateway-conformance, it runs in CI and since #181 we also test IPNS content paths, including raw ipns-record fixtures imported in .github/workflows/gateway-conformance.yml
.
So no need for additional testing imo. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hacdias thanks! two asks inline 🙏
Ping @lidel |
Co-authored-by: Marcin Rataj <[email protected]>
Ensures IPNS_RECORD_GATEWAY_URL is prefered, then we fallback to PROXY_GATEWAY_URL, and finally KUBO_RPC_URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, pushed cosmetic fix for better ux and rebased
Note: this should be safe to merge, as it does not impact Rhea deployments which all have KUBO_RPC_URL set:
https://github.com/ipfs/bifrost-gateway/blob/04eb5db2f270271b0675de1a90708d2d173dd780/Dockerfile#L34
Towards #151, allows resolving IPNS without
KUBO_RPC_URL
being setIPNS_RECORD_GATEWAY_URL
KUBO_RPC_URL
or modernIPNS_RECORD_GATEWAY_URL
orPROXY_GATEWAY_URL
with support forapplication/vnd.ipfs.ipns-record
responsesNot sure what to do regarding testing here. We haven't had testing before and it seems a bit complicated to automate. I tried locally with both Kubo gateway and Routing V1 and it worked 🥳