-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gateway): improved templates, user friendly errors #298
Conversation
Codecov Report
@@ Coverage Diff @@
## main #298 +/- ##
==========================================
- Coverage 49.37% 48.20% -1.18%
==========================================
Files 279 281 +2
Lines 33598 33646 +48
==========================================
- Hits 16590 16220 -370
- Misses 15276 15737 +461
+ Partials 1732 1689 -43
|
I'm opening this for review. Please give me feedback regarding error messages and other things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. A few things:
- This needs a changelog entry.
- How does someone customize this for their own needs? 3 immediate examples I see:
- (most important) how does ipfs.io gateway customize this for their product
- (maybe) Kubo default (which can encourage someone to install Kubo for themselves)
- (likely not as important) bifrost-gateway default
01d1085
to
fd662bc
Compare
Very good question. And I think the answer depends on what you want to customize. What do you need to customize? Right now none of the templates are or have been customizable (directory index, DAG index, and now error). I removed the Kubo hardcoded link and added customisable links for the menu. |
ece7d2a
to
202f364
Compare
b34d3c7
to
699bbc3
Compare
d215a1b
to
00428cd
Compare
557b1ba
to
d4f57e7
Compare
ab987b2
to
110e584
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks are green in Kubo: ipfs/kubo#9904. Merging. |
Closes #262. This PR does the following:
go generate
.twitter
andopengraph
meta tags and just use standard<title>
and<meta description
.As usual, instructions on how to test the templates are in
gateway/assets/README.md
.