Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add wemeetagain as JavaScript member #171

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

wemeetagain
Copy link
Member

Summary

Why do you need this?

I (@wemeetagain) am working with @achingbrain on maintaining and improving js-libp2p tooling and libraries, many of which exist in the ipfs organization. I would like to become a member of the javascript team so I can review PRs, take over stale PRs, etc. in these repos.

What else do we need to know?

no deadline

DRI: @achingbrain @SgtPooki

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

- add @wemeetagain as a member of the organization
- add @wemeetagain as a member of the Repos - JavaScript team
@github-actions
Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipfs

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # github_membership.this["wemeetagain"] will be created
  + resource "github_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "wemeetagain"
    }

  # github_team_membership.this["repos - javascript:wemeetagain"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "1433120"
      + username = "wemeetagain"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

Copy link
Contributor

@laurentsenta laurentsenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see you again @wemeetagain :)
Terraform plan looks good; waiting for @SgtPooki or @achingbrain to take a look and merge.

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SgtPooki
Copy link
Member

SgtPooki commented Oct 3, 2023

@laurentsenta I don't have permissions to merge on github-mgmt

@galargh galargh merged commit b191da9 into ipfs:master Oct 4, 2023
6 checks passed
@galargh
Copy link
Contributor

galargh commented Oct 4, 2023

@wemeetagain FYI, you should receive an invite to your email inbox sometime soon. We do want to make it more obvious that this additional step is required for some operations, but we're not there yet.

@wemeetagain
Copy link
Member Author

thanks @galargh

@wemeetagain wemeetagain deleted the patch-1 branch October 4, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants