-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grant shipyard admin to rainbow repo #205
Conversation
The following access changes will be introduced as a result of applying the plan: Access Changes
|
I think you need to remove yourself from "members" first. |
Wait, no, this is just a per-repo thing. NVM. |
Yep, it is just for specific repo. Simplified and made rainbow/someguy do the same thing we do for bifrost-gateway. |
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform plansipfs
|
- kubo maintainers | ||
- w3dt-stewards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but FYI it looks like the kubo-maintainers group is a strict subset of the w3dt-stewards group. Did you mean to add both?
Side note: w3dt-stewards is probably too big (and of course is a highly dated name) but can tackle that in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i blindly replicated what we already had in similar repo.
cleaning up these teams will be something for a future PR.
Summary
I need admin to adjust
required_status_checks
to new value due to change of test in ipfs/rainbow#117Why do you need this?
Right now, can't merge PR because it requires test that no longer exists:
(we replaced this with matrix that runs 3 variants)
cc @hacdias for visibility
What else do we need to know?
Is there a better way of doing this? I'm hesitant guessing what strings should be put in
required_status_checks
, so editing via Github GUI feels safer.DRI: myself
Reviewer's Checklist