Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add self as collaborator to go-delegated-routing #31

Closed
wants to merge 2 commits into from

Conversation

willscott
Copy link
Contributor

Have PRs, but can't tag reviewers.

Would make this as a PR I can tag reviewers against in this repo as requested by stewards, but can't per #30

Have PRs, but can't tag reviewers.

Would make this as a PR I can tag reviewers against in this repo as requested by stewards, but can't per ipfs#30
@willscott willscott requested a review from a team as a code owner August 1, 2022 08:33
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipfs

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # github_repository_collaborator.this["go-delegated-routing:willscott"] will be created
  + resource "github_repository_collaborator" "this" {
      + id                          = (known after apply)
      + invitation_id               = (known after apply)
      + permission                  = "push"
      + permission_diff_suppression = false
      + repository                  = "go-delegated-routing"
      + username                    = "willscott"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

@galargh
Copy link
Contributor

galargh commented Aug 1, 2022

I was wondering, can we add go-delegated-routing to Repos - Go instead? I can move forward with #32 if that's OK.

Also, do you happen to know why we have both Repos - Go and Merge - Go team? I suspect that it wasn't the case when they were being created but right now it seems that Merge - Go is a subset of Repos - Go so maybe we could consolidate the two.

@galargh
Copy link
Contributor

galargh commented Aug 1, 2022

Have PRs, but can't tag reviewers.

Oh wait, that we can easily broaden. We could give everyone in the org triage access here which would allow requesting reviews - #33

@willscott
Copy link
Contributor Author

Fine with #32 instead

@willscott
Copy link
Contributor Author

Merge is a relatively small number of pretty trusted people. Those people should generally be okay to merge to e.g. protected main branches / cut releases. I would also assert that those people should have the trust to update repo permissions and add collaborators

@galargh
Copy link
Contributor

galargh commented Aug 1, 2022

Closing since I merged #32

Merge is a relatively small number of pretty trusted people. Those people should generally be okay to merge to e.g. protected main branches / cut releases. I would also assert that those people should have the trust to update repo permissions and add collaborators

Got it. Just wondered because in practice Merge - Go has no more access to any repo than Repos - Go

@galargh galargh closed this Aug 1, 2022
github-actions bot pushed a commit that referenced this pull request Sep 14, 2022
galargh added a commit that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants