Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide default grafana dashboard #101

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Mar 29, 2024

Title

feat: provide default grafana dashboard

Description

Part of #18 (comment)

This PR adds a custom dashboard I created (open to improvement.. just update the json without breaking the datasource provisioning!) as well as a nodejs dashboard: https://grafana.com/grafana/dashboards/11956-nodejs-metrics/

There are other dashboards at https://grafana.com/grafana/dashboards/?search=nodejs but the one linked above seemed to work the best. It was migrated from old dashboard panels that used angularjs as well.

Notes & open questions

prometheus and grafana can be spun up easily with a simple cd config && docker compose up -d

libp2p metrics

image image

nodejs metrics

image

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@SgtPooki SgtPooki requested a review from 2color March 29, 2024 22:35
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

@SgtPooki SgtPooki self-assigned this Mar 29, 2024
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@achingbrain achingbrain merged commit a9bb04f into main Apr 10, 2024
4 checks passed
@achingbrain achingbrain deleted the feat/grafana-dashboards branch April 10, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants