Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debugging scripts and playwright config #103

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Mar 29, 2024

Title

fix: debugging scripts and playwright config

Description

various fixes of the debugging scripts until-death.sh and test-gateways.sh.

  • shutting down the server
  • shutting down subprocesses
  • not logging to files (users can do this themselves when calling it if they want.)

Also added time-permutations.sh script to allow for a battery of until-death.sh scripts for debugging failures (and keeping logs around) like in #18

Also some adjustments to playwright config to allow env var overriding.

Notes & open questions

see #18 for more details

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Comment on lines +67 to +71
METRICS: process.env.METRICS ?? 'false',
DEBUG: process.env.DEBUG ?? ' ',
// we save to the filesystem so github CI can cache the data.
FILE_BLOCKSTORE_PATH: join(process.cwd(), 'test', 'fixtures', 'e2e', 'blockstore'),
FILE_DATASTORE_PATH: join(process.cwd(), 'test', 'fixtures', 'e2e', 'datastore')
FILE_BLOCKSTORE_PATH: process.env.FILE_BLOCKSTORE_PATH ?? join(process.cwd(), 'test', 'fixtures', 'e2e', 'blockstore'),
FILE_DATASTORE_PATH: process.env.FILE_DATASTORE_PATH ?? (process.cwd(), 'test', 'fixtures', 'e2e', 'datastore')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sometimes you want to disable things when running e2e tests. we should probably allow changing of all env vars here.

@SgtPooki SgtPooki merged commit 2ac9816 into main Mar 29, 2024
6 checks passed
@SgtPooki SgtPooki deleted the fix/debugging-scripts branch March 29, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant