fix: remove uncaught exception handler #154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no circumstances under which it is safe to ignore uncaught exceptions, since the application is left in an unconsistent state.
The node documentation is unequivocal about this:
https://nodejs.org/api/process.html#warning-using-uncaughtexception-correctly
Any code that can throw an exception should be wrapped in a
try/catch
or there should be some other method of handling the error.Change checklist