fix: allow passing cid encoded ipns keys #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on libp2p/js-libp2p#2772 (comment), I've implemented the handling of CID enocded PeerIDs in here. |
SgtPooki
approved these changes
Oct 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
## [@helia/verified-fetch-v2.0.1](https://github.com/ipfs/helia-verified-fetch/compare/@helia/verified-fetch-2.0.0...@helia/verified-fetch-2.0.1) (2024-10-23) ### Bug Fixes * allow passing cid encoded ipns keys ([#117](#117)) ([1836e40](1836e40))
|
🎉 This PR is included in version @helia/verified-fetch-v2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ipns://k51qzi5uqu5dhp48cti0590jyvwgxssrii0zdf19pyfsxwoqomqvfg6bg8qj3s, throws an error: helia:verified-fetch:parse-url-string:error could not parse PeerId string "k51qzi5uqu5dhp48cti0590jyvwgxssrii0zdf19pyfsxwoqomqvfg6bg8qj3s" +0ms InvalidParametersError: Please pass a multibase decoder for strings that do not start with "1" or "Q"Depends on
libp2p/js-libp2p#2773
Change checklist