fix: check eviction filter for new providers #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
fix/check-eviction-filter-for-provider
branch
2 times, most recently
from
9bca946
to
2ed0bae
Compare
When new providers are found, check the eviction filter in `isEvicted` rather than the current list of providers. Fixes #501
achingbrain
force-pushed
the
fix/check-eviction-filter-for-provider
branch
from
2ed0bae
to
fa10e7c
Compare
SgtPooki
approved these changes
May 20, 2024
| @@ -188,7 +188,7 @@ export abstract class AbstractSession<Provider, RetrieveBlockProgressEvents exte | |||
| } | |||
|
|
|||
| isEvicted (provider: Provider): boolean { | |||
| return this.providers.some(prov => this.equals(prov, provider)) | |||
| return this.evictionFilter.has(this.toEvictionKey(provider)) | |||
3 tasks
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When new providers are found, check the eviction filter in
isEvictedrather than the current list of providers.Fixes #501
Change checklist