fix: @helia/* modules validate CID codec #643
Conversation
| if (cid.code !== jsonCodec.code) { | ||
| throw new TypeError('The passed CID had an incorrect codec, it may correspond to a non-JSON block') | ||
| } | ||
|
|
||
| const buf = await this.components.blockstore.get(cid, options) |
There was a problem hiding this comment.
Checks that the codec codes match inside of the JSON.get implementation.
| @@ -115,6 +115,10 @@ class DefaultJSON implements JSON { | |||
| } | |||
|
|
|||
| async get <T> (cid: CID, options: Partial<GetOptions> = {}): Promise<T> { | |||
There was a problem hiding this comment.
Random question, was looking at the GetOptions type. It contains codec: BlockCodec property which is passed to the blockstore.get call. Is this ever used?
|
Before I finish the other modules, does this approach look ok? |
tabcat
changed the title
This looks good to me. It should be pretty straightforward |
|
The |
|
|
Title
fix: @helia/* modules validate CID codec
Description
Closes: #377
@helia/* modules related to importing structured data, e.g. @helia/json; @helia/strings, check CID that is handed to
.getmethod.If the CID code does not match the codec of the importer then it rejects with a TypeError.
Notes & open questions
Change checklist