Variable viewer height

[jessicaschilling]

• Makes PDF viewer height take up full screen height per PDF viewer doesn't scale to page #1434
• Unfortunately can't be based entirely on Tachyons references since fixed pixel heights for assorted header items
• Side note: something similar may be happening in Expand links to bottom ipld/explore.ipld.io#53

closes #1434

[jessicaschilling]

@hacdias and/or @alanshaw, can you please take a look? There may be a more elegant way of doing this via Tachyons only, but I wasn't finding it -- there are enough explicitly sized things in the header matter of the file viewer and in the app header at medium/below width that I couldn't find a way myself. Thanks!

[hacdias]

I think it's okay for now. Thanks for this @jessicaschilling 😃

P.S.: I'm not aware of any way of doing this only with tachyons.

[jessicaschilling]

@hacdias -- thanks for the review. I'm a bit antsy about releasing this on my own; any suggestions for someone who could walk through with me in your absence?

[alanshaw]

❤️ I tried this out and it works for me 👍 It's probably fine but the magic numbers make me a bit nervous and I think it could be improved by using flexbox instead (which may allow a tachyons only solution too).

[jessicaschilling]

Thanks @alanshaw -- added comments. It'd be great to get this out to people, but I've not released webui before -- do you have any time at all to advise on the process or could I bribe you to do so? Is this worthy of its own release or should it be batched with other small fixes?

[alanshaw]

I've not done it before - did you see https://github.com/ipfs-shipyard/ipfs-webui#releasing-a-new-version-of-the-webui ?

I think #1432 needs to go in asap so might be worth getting both in before a new release.

cc @lidel

[lidel]

👌

[lidel]

(We now wait for master to build and copy CID)

I'll test it and PR repos listed in #releasing-a-new-version-of-the-webui and cc @jessicaschilling as a passenger on the release train ;-)