fix(i18n): 🩹 Fixing store for localStorageBackend plugin #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whizzzkid
force-pushed
the
fix/2190-localstorage
branch
from
e0d81d8
to
bbda6eb
Compare
Signed-off-by: Nishant Arora <[email protected]>
whizzzkid
force-pushed
the
fix/2190-localstorage
branch
from
bbda6eb
to
4bebefa
Compare
SgtPooki
requested changes
Feb 7, 2024
There was a problem hiding this comment.
I don't see anything inherently wrong with the code here, but I also don't see that this fixes the problems in the referenced issue.
I posted some comments on that issue, but I think there are higher priority items. Folks can allow localStorage/cookie access explicitly for the URL they're using to access the webui as a workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2190