feat: Enable to use defaultDagBuilder with custom builders #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clostao
changed the title
clostao
changed the title
clostao
changed the title
achingbrain
requested changes
Sep 13, 2024
|
I pushed the requested changes lmk if I can furtherly help |
|
Any news on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to add some additional optional metadata to directory's IPLD objects having an almost equal IPLD object as the IPFS standard. For this reason, we would want to use the
defaultDagBuilderbut customising just how file and directories IPLD objects are formed.For achieving this I added two additional fields to
DagBuilderOptions&ImporterOptionsthat would override thedirBuilder&fileBuilderif that option is provided.