Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return gateway href in .info response #850

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Nov 14, 2024

In order to not re-add the multiaddr dependency, we're just returning the gateway response as a string. Users will need to parse the string with @multiformats/multiaddr or other means.

We are reading the gateway href from $REPO_PATH/gateway file now.

Fixes #831

Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

@SgtPooki SgtPooki self-assigned this Nov 14, 2024
@SgtPooki SgtPooki changed the title fix: return gateway maddr in .info response fix: return gateway href in .info response Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add back controller.api.gatewayHost and controller.api.gatewayPort or similar
1 participant