Skip to content

Commit

Permalink
chore: use + as separator
Browse files Browse the repository at this point in the history
subjective, but looks better than ,
  • Loading branch information
lidel committed Aug 13, 2024
1 parent 222a403 commit 7b2d58e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion cmd/ipfs/kubo/daemon.go
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,7 @@ func printLibp2pPorts(node *core.IpfsNode) {
protocols = append(protocols, protocol)
}
sort.Strings(protocols)
fmt.Printf("Swarm listening on %s (%s)\n", host, strings.Join(protocols, ","))
fmt.Printf("Swarm listening on %s (%s)\n", host, strings.Join(protocols, "+"))
}
fmt.Printf("Run 'ipfs id' to inspect announced and discovered multiaddrs of this node.\n")
}
Expand Down
10 changes: 5 additions & 5 deletions docs/changelogs/v0.30.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ Repo version: 16
System version: amd64/linux
Golang version: go1.22.5
PeerID: 12D3KooWQ73s1CQsm4jWwQvdCAtc5w8LatyQt7QLQARk5xdhK9CE
Swarm listening on 127.0.0.1:4001 (TCP,UDP)
Swarm listening on 192.0.2.10:4001 (TCP,UDP)
Swarm listening on [::1]:4001 (TCP,UDP)
Swarm listening on [2001:0db8::10]:4001 (TCP,UDP)
Swarm listening on 127.0.0.1:4001 (TCP+UDP)
Swarm listening on 192.0.2.10:4001 (TCP+UDP)
Swarm listening on [::1]:4001 (TCP+UDP)
Swarm listening on [2001:0db8::10]:4001 (TCP+UDP)
Run 'ipfs id' to inspect announced and discovered multiaddrs of this node.
RPC API server listening on /ip4/127.0.0.1/tcp/5001
WebUI: http://127.0.0.1:5001/webui
Expand All @@ -75,7 +75,7 @@ Daemon is ready
```

The previous lengthy listing of all listener and announced multiaddrs has been removed due to its complexity, especially with modern libp2p nodes sharing multiple transports and long lists of `/webtransport` and `/webrtc-direct` certhashes.
The output now features a simplified list of swarm listeners, displayed in the format `host:port (TCP,UDP)`, which provides essential information for debugging connectivity issues, particularly related to port forwarding.
The output now features a simplified list of swarm listeners, displayed in the format `host:port (TCP+UDP)`, which provides essential information for debugging connectivity issues, particularly related to port forwarding.
Announced libp2p addresses are no longer printed on startup, because libp2p may change or augument them based on AutoNAT, relay, and UPnP state. Instead, users are prompted to run `ipfs id` to obtain up-to-date list of listeners and announced multiaddrs in libp2p format.

### 📝 Changelog
Expand Down

0 comments on commit 7b2d58e

Please sign in to comment.