-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gateway): update gateway api, no multi-range support #10024
Conversation
c6d99b2
to
04dafd0
Compare
04dafd0
to
58fa0c7
Compare
428fade
to
bcc9a3b
Compare
0f08d51
to
1fd57b6
Compare
1fd57b6
to
5b78057
Compare
Pushed ae6b113 with pinned conformance CI revision to double-check if unreleased 404 tests from ipfs/gateway-conformance#131 and ipfs/gateway-conformance#132 pass against this PR. Will check result tomorrow. |
@lidel seem to pass 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight concern on user data loss caused by CAR root change
Someone probably built things that depend on exporting CAR from gateway and then importing it to Kubo.
By removing the CAR root we introduce a surface for data loss, as exported full DAG is no longer pinned by default on `ipfs dag import.
We should double check if we change default behavior or not, and document what changed:
- see if we keep useful root when we know it: feat(gateway): more explicit IPFSBackend and no multi-range boxo#369 (comment)
- add/update changelog for Kubo 0.23.md and note when CAR responses no longer have a meaningful root explicitly listed in CARv1, but use bogus
bafkqaaa
as a placeholder (4XX/5XX errors only, or more?)
7c2aee0
to
7f4bed8
Compare
Please check my comment on that thread.
I added the information about what to expect. |
d5e2d57
to
10bc6cd
Compare
10bc6cd
to
4cb6b9a
Compare
4cb6b9a
to
1e979ed
Compare
1e979ed
to
a3c45c0
Compare
Requires:
TestGatewayMultiRange