-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update boxo, go-libp2p, and internalize mplex #10095
Merged
Merged
+370
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorropo
previously approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thx
hacdias
force-pushed
the
internalize-mplex
branch
3 times, most recently
from
August 22, 2023 16:54
978f323
to
5bdea7b
Compare
hacdias
force-pushed
the
internalize-mplex
branch
from
August 22, 2023 16:57
5bdea7b
to
ded1f00
Compare
Jorropo
reviewed
Aug 22, 2023
BigLep
changed the title
chore: update boxo and internalize mplex
chore: update boxo, go-libp2p, and internalize mplex
Aug 22, 2023
This was referenced Aug 22, 2023
Closed
hacdias
force-pushed
the
internalize-mplex
branch
from
August 23, 2023 07:52
70dd324
to
94fd3ac
Compare
Jorropo
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I trust you on the content of the mplex copy
hacdias
force-pushed
the
internalize-mplex
branch
from
August 24, 2023 06:04
58fabe2
to
e5e1ae7
Compare
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10094 (comment).
Remaining mentions of
/quic
(without-v1
) seem to only be changelogs and migrations tests.Config migration in ipfs/fs-repo-migrations#174.