Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update boxo, go-libp2p, and internalize mplex #10095

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Aug 22, 2023

See #10094 (comment).

Remaining mentions of /quic (without -v1) seem to only be changelogs and migrations tests.

image

Config migration in ipfs/fs-repo-migrations#174.

@hacdias hacdias added the skip/changelog This change does NOT require a changelog entry label Aug 22, 2023
Jorropo
Jorropo previously approved these changes Aug 22, 2023
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx

core/node/libp2p/internal/mplex/conn.go Outdated Show resolved Hide resolved
core/node/libp2p/internal/mplex/stream.go Outdated Show resolved Hide resolved
core/node/libp2p/internal/mplex/transport.go Outdated Show resolved Hide resolved
core/node/libp2p/internal/mplex/transport_test.go Outdated Show resolved Hide resolved
@hacdias hacdias force-pushed the internalize-mplex branch 3 times, most recently from 978f323 to 5bdea7b Compare August 22, 2023 16:54
@hacdias hacdias dismissed Jorropo’s stale review August 22, 2023 16:55

will need review again

@hacdias hacdias requested a review from Jorropo August 22, 2023 16:55
@hacdias hacdias self-assigned this Aug 22, 2023
@hacdias hacdias marked this pull request as ready for review August 22, 2023 18:36
@hacdias hacdias requested review from lidel and a team as code owners August 22, 2023 18:36
@hacdias hacdias requested a review from Jorropo August 22, 2023 18:36
@BigLep BigLep changed the title chore: update boxo and internalize mplex chore: update boxo, go-libp2p, and internalize mplex Aug 22, 2023
This was referenced Aug 22, 2023
go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I trust you on the content of the mplex copy

docs/config.md Show resolved Hide resolved
@hacdias hacdias enabled auto-merge (squash) August 24, 2023 06:04
@hacdias hacdias merged commit 5ea5825 into master Aug 24, 2023
16 checks passed
@hacdias hacdias deleted the internalize-mplex branch August 24, 2023 06:11
@p-shahi p-shahi mentioned this pull request Sep 7, 2023
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does NOT require a changelog entry
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants