-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add public.records gateway #289
Conversation
To access the public.records gateway, a Handshake resolver is required, such as https://impervious.com/fingertip or https://impervious.com/beacon.
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
With fingertip running (auto config)Without fingertip running@lidel @meandavejustice How do you feel about adding this gateway? I imagine it could make the CI workflows more difficult |
This also brings up an interesting question.. should we provide a way for gateways to supply prereq info? For this gateway, users need a Handshake resolver. Displaying that information could be useful |
@theshakeweb would you be willing to create a github action that supports validation of Handshake URLs? It looks like the test at https://github.com/handshake-org/hsd/blob/master/test/http-test.js does mostly what we would need. Without that, adding this gateway would block any PRs once #248 is done. |
Understood. Yes, willing to create this github action. Thanks for your thoughtful consideration. |
That's fantastic! We would greatly appreciate it =) |
FWIW we already have That is fine – people who have that will see them as online, which is a nice feature. Agreed, we should have the ability to test HNS on CI, so they are not mistaken for invalid ones and removed during periodical cleanup (like we did in #40) |
Opened #364 for addressing special request handling URLs in CI However, @theshakeweb, it looks like public.records/ipfs gateway is no longer working. I tried at the preview as well as locally, and neither are working using fingertip+brave nor with the beacon browser |
You are correct. The gateway is still active but had to be relocated to a new Handshake domain. It now operates at shake.speare/ipfs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domain is inactive. needs updated, or PR closed
Shake.speare is a gateway on Handshake, secured by DANE. To access the shake.speare gateway, a Handshake resolver is required, such as https://impervious.com/fingertip or https://impervious.com/beacon. The gateway was previously hosted at public.records but had to be relocated to this new Handshake domain.
Public.records is a gateway on Handshake, secured by DANE. To access the public.records gateway, a Handshake resolver is required, such as https://impervious.com/fingertip or https://impervious.com/beacon.