Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add public.records gateway #289

Closed
wants to merge 5 commits into from
Closed

Conversation

theshakeweb
Copy link

Public.records is a gateway on Handshake, secured by DANE. To access the public.records gateway, a Handshake resolver is required, such as https://impervious.com/fingertip or https://impervious.com/beacon.

To access the public.records gateway, a Handshake resolver is required, such as https://impervious.com/fingertip or https://impervious.com/beacon.
@welcome
Copy link

welcome bot commented Sep 2, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@SgtPooki SgtPooki requested a review from a team as a code owner September 23, 2022 23:23
@SgtPooki
Copy link
Member

With fingertip running (auto config)

image

Without fingertip running

image

@lidel @meandavejustice How do you feel about adding this gateway? I imagine it could make the CI workflows more difficult

@SgtPooki SgtPooki added exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked need/community-input Needs input from the wider community labels Sep 23, 2022
@SgtPooki SgtPooki self-assigned this Sep 23, 2022
@SgtPooki
Copy link
Member

This also brings up an interesting question.. should we provide a way for gateways to supply prereq info? For this gateway, users need a Handshake resolver. Displaying that information could be useful

@SgtPooki
Copy link
Member

@theshakeweb would you be willing to create a github action that supports validation of Handshake URLs? It looks like the test at https://github.com/handshake-org/hsd/blob/master/test/http-test.js does mostly what we would need. Without that, adding this gateway would block any PRs once #248 is done.

@theshakeweb
Copy link
Author

@theshakeweb would you be willing to create a github action that supports validation of Handshake URLs? It looks like the test at https://github.com/handshake-org/hsd/blob/master/test/http-test.js does mostly what we would need. Without that, adding this gateway would block any PRs once #248 is done.

Understood. Yes, willing to create this github action. Thanks for your thoughtful consideration.

@SgtPooki
Copy link
Member

@theshakeweb would you be willing to create a github action that supports validation of Handshake URLs? It looks like the test at https://github.com/handshake-org/hsd/blob/master/test/http-test.js does mostly what we would need. Without that, adding this gateway would block any PRs once #248 is done.

Understood. Yes, willing to create this github action. Thanks for your thoughtful consideration.

That's fantastic! We would greatly appreciate it =)

@lidel
Copy link
Member

lidel commented Oct 21, 2022

How do you feel about adding this gateway? I imagine it could make the CI workflows more difficult

FWIW we already have .onion, so with HNS we have two use cases of special gateways that require custom routing or resolver.

That is fine – people who have that will see them as online, which is a nice feature.

Agreed, we should have the ability to test HNS on CI, so they are not mistaken for invalid ones and removed during periodical cleanup (like we did in #40)

@SgtPooki
Copy link
Member

SgtPooki commented Jan 10, 2023

Opened #364 for addressing special request handling URLs in CI

However, @theshakeweb, it looks like public.records/ipfs gateway is no longer working. I tried at the preview as well as locally, and neither are working using fingertip+brave nor with the beacon browser

URL to test: https://public.records/ipfs/bafybeibwzifw52ttrkqlikfzext5akxu7lz4xiwjgwzmqcpdzmp3n5vnbe?now=1673382715453&filename=1x1.png#x-ipfs-companion-no-redirect

image

@SgtPooki SgtPooki added need/author-input Needs input from the original author and removed exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked need/community-input Needs input from the wider community labels Jan 10, 2023
@theshakeweb
Copy link
Author

Opened #364 for addressing special request handling URLs in CI

However, @theshakeweb, it looks like public.records/ipfs gateway is no longer working. I tried at the preview as well as locally, and neither are working using fingertip+brave nor with the beacon browser

URL to test: https://public.records/ipfs/bafybeibwzifw52ttrkqlikfzext5akxu7lz4xiwjgwzmqcpdzmp3n5vnbe?now=1673382715453&filename=1x1.png#x-ipfs-companion-no-redirect

image

You are correct. The gateway is still active but had to be relocated to a new Handshake domain. It now operates at shake.speare/ipfs.

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain is inactive. needs updated, or PR closed

Shake.speare is a gateway on Handshake, secured by DANE. To access the shake.speare gateway, a Handshake resolver is required, such as https://impervious.com/fingertip or https://impervious.com/beacon.

The gateway was previously hosted at public.records but had to be relocated to this new Handshake domain.
@lidel lidel added status/blocked Unable to be worked further until needs are met and removed need/author-input Needs input from the original author labels Jan 12, 2023
@SgtPooki
Copy link
Member

SgtPooki commented Jun 8, 2023

it looks like shake.speare is still failing all checks at the preview URL:

image

@SgtPooki SgtPooki closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/blocked Unable to be worked further until needs are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants