Add integrated nopfs-content blocking to the gateway #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is pending some go.mod bubbling.
hsanjuan
commented
Oct 12, 2023
setup.go
Outdated
Comment on lines
304
to
309
| fetcherConfig.PrototypeChooser = dagpb.AddSupportToChooser(func(lnk ipld.Link, lnkCtx ipld.LinkContext) (ipld.NodePrototype, error) { | ||
| if tlnkNd, ok := lnkCtx.LinkNode.(schema.TypedLinkNode); ok { | ||
| return tlnkNd.LinkTargetNodePrototype(), nil | ||
| } | ||
| return basicnode.Prototype.Any, nil | ||
| }) |
There was a problem hiding this comment.
I'm not sure this is... I wish it was more hidden, i.e. something that happens in NewBasicResolver.
@lidel this is indeed the default? https://github.com/ipfs/boxo/blob/main/fetcher/impl/blockservice/fetcher.go#L127
|
It ended up pretty simple after ipfs-shipyard/nopfs#21 |
Closed
|
We will need a follow-up to subscribe to lists.... we need to make them append-only first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some things need bubbling/merging, starting with ipfs/boxo#484