Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): build and publish staging docker images #80

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Feb 9, 2024

Closes #78.

@hacdias hacdias self-assigned this Feb 9, 2024
@hacdias
Copy link
Member Author

hacdias commented Feb 9, 2024

@aschmahmann do you know why we use our own script to generate the Docker labels instead of something simpler (e.g. https://github.com/docker/metadata-action)?

@lidel lidel force-pushed the docker-staging branch 2 times, most recently from a6a5823 to b956db1 Compare February 11, 2024 22:37
@lidel
Copy link
Member

lidel commented Feb 11, 2024

The way we generate labels comes from go-ipfs and predates Github Actions.

We could refactor it, as long a new method gives us the same level of flexibility around label filenames, but I'd say it is better to use the same setup everywhere (kubo/rainbow/someguy) right now, and spend time elsewhere. Refactor across all repos (in unified fashion) can be done after more pressing IPDX work lands this year.

@lidel lidel changed the title chore: build staging docker images feat(ci): build and publish staging docker images Feb 11, 2024
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, ported some user-friendly Docker docs.

@lidel lidel enabled auto-merge (squash) February 11, 2024 22:43
@lidel lidel merged commit 018e2c2 into main Feb 11, 2024
10 checks passed
@lidel lidel deleted the docker-staging branch February 11, 2024 22:55
@lidel
Copy link
Member

lidel commented Feb 11, 2024

@ns4plabs @aschmahmann fyi I've created staging branch, and confirmed images for that branch are build correctly:

https://github.com/ipfs/rainbow/actions/runs/7865229424 produced ghcr.io/ipfs/rainbow:staging-2024-02-11-018e2c2, all tags can be listed at https://github.com/ipfs/rainbow/pkgs/container/rainbow/

You can use this setup for deterministic builds that we then can run as staging experiments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Automated Docker builds for main and staging branches
2 participants