fix: handle helia-sw query from _redirects #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 tasks
|
@SgtPooki is this draft ready for review or needs more work? lmk if a second pair of eyes on this would be helpful. |
|
@lidel I just needed some time to do some testing |
SgtPooki
changed the title
SgtPooki
commented
Mar 2, 2024
| import Config from './components/config.tsx' | ||
| import { ConfigContext } from './context/config-context.tsx' | ||
| import HelperUi from './helper-ui.tsx' | ||
| import { isConfigPage } from './lib/is-config-page.ts' | ||
| import { isPathOrSubdomainRequest, findOriginIsolationRedirect } from './lib/path-or-subdomain.ts' | ||
| import { isPathOrSubdomainRequest } from './lib/path-or-subdomain.ts' |
There was a problem hiding this comment.
moved to service-worker-context
Comment on lines
+1
to
+14
| /** | ||
| * @file This file contains the ServiceWorkerProvider component which is used to register the service worker, | ||
| * and provide the isServiceWorkerRegistered state to the rest of the app. | ||
| * | ||
| * URL / location logic dependent upon the service worker being registered should be handled here. Some examples of this are: | ||
| * | ||
| * Before the Service Worker is registered (e.g. first requests to root hosted domain or subdomains): | ||
| * | ||
| * 1. Being redirected from _redirects file to a ?helia-sw= url | ||
| * 2. The app is loaded because service worker is not yet registered, we need to reload the page so the service worker intercepts the request | ||
| * | ||
| * After the service worker is loaded. Usually any react code isn't loaded, but some edge cases are: | ||
| * 1. The page being loaded using some /ip[fn]s/<path> url, but subdomain isolation is supported, so we need to redirect to the isolated origin | ||
| */ |
Comment on lines
+35
to
+40
| if (windowLocation.href !== window.location.href) { | ||
| /** | ||
| * We're at a domain with ?helia-sw=, we can reload the page so the service worker will | ||
| * capture the request | ||
| */ | ||
| window.location.replace(windowLocation.href) |
There was a problem hiding this comment.
this check could be more explicit for future devs, but translateIpfsRedirectUrl should make understanding this easy.
Comment on lines
+45
to
+49
| void findOriginIsolationRedirect(windowLocation).then((originRedirect) => { | ||
| if (originRedirect !== null) { | ||
| window.location.replace(originRedirect) | ||
| } | ||
| }) |
There was a problem hiding this comment.
/?helia-sw= redirect will load path URL.. if not handled by service worker for whatever reason (it should be, 99.99% of the time) then this will redirect that path request to subdomain if supported.
| @@ -32,7 +72,7 @@ export const ServiceWorkerProvider = ({ children }): JSX.Element => { | |||
| } | |||
| } | |||
| void doWork() | |||
| }, []) | |||
| }, [isServiceWorkerRegistered]) | |||
There was a problem hiding this comment.
we're dependent upon isServiceWorkerRegistered, so we need to execute this effect more than a single time now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Description
Fixes an issue where helia-service-worker-gateway will redirect
<domain>/<requestedPath>to<domain>/?helia-sw=/<requestedPath>and then not be handled by the service-worker appropriately.Notes & open questions
still debugging this. WIP
Change checklist