Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support decoding ArrayBuffers #95

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

achingbrain
Copy link
Member

Expands supported input types to include ArrayBuffers to make it easiser for users to use modules like fetch that don't return Uint8Arrays.

Expands supported input types to include `ArrayBuffer`s to make it
easiser for users to use modules like `fetch` that don't return
`Uint8Array`s.
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same concern as ipld/js-dag-json#127 (review) but not strong enough to reject

@achingbrain achingbrain merged commit 3d4eaf8 into master Feb 16, 2024
18 checks passed
@achingbrain achingbrain deleted the feat/support-decoding-array-buffers branch February 16, 2024 11:01
github-actions bot pushed a commit that referenced this pull request Feb 16, 2024
## [4.1.0](v4.0.8...v4.1.0) (2024-02-16)

### Features

* support decoding ArrayBuffers ([#95](#95)) ([3d4eaf8](3d4eaf8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants