Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on protobufjs #31

Open
Gozala opened this issue Sep 29, 2022 · 6 comments
Open

Remove dependency on protobufjs #31

Gozala opened this issue Sep 29, 2022 · 6 comments

Comments

@Gozala
Copy link
Collaborator

Gozala commented Sep 29, 2022

From the private thread discussing the issue

protobufjs is big, complex, uses eval and has circular dependencies

image

Seem like there is even viable alternatives out there https://github.com/timostamm/protobuf-ts

Ideally we won't even pull in the peps here and go with approach @rvagg did in https://github.com/ipld/js-dag-pb/blob/master/src/pb-encode.js

@talentlessguy
Copy link
Contributor

ETA on this? or it's low priority

@tsemachh
Copy link

I am also looking into it , we can't use it in chrome extension as it requires manifest V3 which forbids eval usage

@tuler
Copy link

tuler commented May 24, 2024

Also it brings ~4.9mb to the install size.

@Gozala
Copy link
Collaborator Author

Gozala commented May 30, 2024

There is no ETA or anyone actually working on it, if someone wants to take a stab at it I'd be happy to help, but I don't have cycles to do the work myself.

@ikreymer
Copy link

ikreymer commented Jun 1, 2024

We might have to drop IPFS support in ArchiveWeb.page extension temporarily until this is resolved, since this is blocking the move to MV3 :( (with MV2 deprecation starting next week)

Edit: Still investigating, may be less of an issue after updating to latest @ipld/unifx

We can help test this as well in our extension, but otherwise fairly time constrained as well

@tsemachh
Copy link

tsemachh commented Jun 1, 2024

I would patch it as PR is still pending from some reason see:
protobufjs/protobuf.js#1941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants