-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on protobufjs #31
Comments
ETA on this? or it's low priority |
I am also looking into it , we can't use it in chrome extension as it requires manifest V3 which forbids eval usage |
Also it brings ~4.9mb to the install size. |
There is no ETA or anyone actually working on it, if someone wants to take a stab at it I'd be happy to help, but I don't have cycles to do the work myself. |
Edit: Still investigating, may be less of an issue after updating to latest @ipld/unifx We can help test this as well in our extension, but otherwise fairly time constrained as well |
I would patch it as PR is still pending from some reason see: |
From the private thread discussing the issue
Seem like there is even viable alternatives out there https://github.com/timostamm/protobuf-ts
Ideally we won't even pull in the peps here and go with approach @rvagg did in https://github.com/ipld/js-dag-pb/blob/master/src/pb-encode.js
The text was updated successfully, but these errors were encountered: